Can register using an email address via identity server #1034
Conversation
|
@richvdh how do I request review on this PR? |
I've set the review flag for you! 😄 |
| @@ -54,6 +54,7 @@ | |||
| binmode(STDOUT, ":utf8"); | |||
|
|
|||
| our $BIND_HOST = "localhost"; | |||
| our $ID_SERVER_PORT = 34586; | |||
There was a problem hiding this comment.
Why do we now need to set an explicit port ooi?
There was a problem hiding this comment.
So that it can be added to trusted servers in homeserver configuration. I suppose that each time id_server_fixture is called random port is assigned.
There was a problem hiding this comment.
Oh yes, I'm blind. We don't need it for Synapse because there's an option to trust all ID servers, right?
There was a problem hiding this comment.
It is quite messy in Synapse. For example in /register/email/requestToken id_server field will be just ignored. I could not figure out how does it work in user-interactive authentication. I didn't either found option to trust all ID servers in Synapse.
|
Is this blocked until matrix-org/dendrite#1837 lands? |
Co-authored-by: Erik Johnston <erikj@jki.re>
Co-authored-by: Erik Johnston <erikj@jki.re>
Good question, I think this PR and the one mentioned by you blocks each other. I can think of following way to resolve this:
BTW this test case is not whitelisted in dendrite nor synapse for now - only in this branch |
There was a problem hiding this comment.
As I wrote on matrix-org/dendrite#1837, I'm not sure that this is something we should be introducing in new code. In particular, the concept of a "trusted" identity server is pretty broken. It's likely we'll remove that option soon in Synapse (matrix-org/synapse#5881), and we certainly shouldn't be adding more code that relies on it.
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
|
We want to stick with HS sending validation emails - see this issue, so closing this PR. |
New test case. Why is it neccessary? Test case
Can register using an email addressexpect homeserver to send email. There is currently no way to test configuration when identity server is requested to send email (by /requestToken endpoint) to mocked identity server. When received, email is considered verified (the part with /submitToken is skipped).There is backward-compatible change in configuration provided to Dendrite. Is is described in PR for Dendrite
Signed-off-by:
Piotr Kozimor <p1996k@gmail.com>