-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can register using an email address via identity server #1034
Closed
PiotrKozimor
wants to merge
11
commits into
matrix-org:develop
from
PiotrKozimor:test/registration-via-email-id-server
Closed
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
7ae9689
Add cache volume for quicker tests
PiotrKozimor f7756c3
Test register using an email address via identity server
PiotrKozimor 0b47dd8
Use validate_identity subroutine for email confirmation
PiotrKozimor fc45e81
Switch to v1 api for mocking requestsToken
PiotrKozimor 77b022c
Identity mock server listen on port 34586
PiotrKozimor 25ea2bf
Cleanup dev scripts
PiotrKozimor 6820e1a
Document new subroutine
PiotrKozimor 12e7e79
Fix typo
PiotrKozimor cc93a05
Remove commented debug prints
PiotrKozimor 4ce3560
More descriptive fail information
PiotrKozimor a139b71
Change indentation of dendrite configuration hash
PiotrKozimor File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we now need to set an explicit port ooi?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So that it can be added to trusted servers in homeserver configuration. I suppose that each time
id_server_fixture
is called random port is assigned.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yes, I'm blind. We don't need it for Synapse because there's an option to trust all ID servers, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is quite messy in Synapse. For example in
/register/email/requestToken
id_server
field will be just ignored. I could not figure out how does it work in user-interactive authentication. I didn't either found option to trust all ID servers in Synapse.