-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🏹 Upgrade Elixir version #1024
🏹 Upgrade Elixir version #1024
Changes from all commits
ac50028
3462458
a9dd673
c7577bd
ee9c11e
5d9587c
44eb88f
65a2849
73b4684
311bbd2
309ad7e
b6a7d46
e56423e
18cde9e
ee36164
20c97fc
dbdc2cf
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -42,3 +42,5 @@ npm-debug.log | |
|
||
# Screenshots taken by Wallaby | ||
/test/integration/screenshots | ||
|
||
.elixir_ls |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
elixir 1.14.5-otp-26 | ||
erlang 26.1.2 | ||
elixir 1.17.3-otp-27 | ||
erlang 27.1.2 | ||
nodejs 20.8.1 |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -56,11 +56,10 @@ if config_env() == :prod do | |
root_source_code_path: File.cwd!(), | ||
tags: %{ | ||
env: sentry_env | ||
}, | ||
included_environments: [sentry_env] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
} | ||
|
||
config :logger, Sentry.LoggerBackend, | ||
level: :warn, | ||
level: :warning, | ||
capture_log_messages: true | ||
end | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -210,7 +210,7 @@ defmodule Arrow.DisruptionRevision do | |
|
||
Enum.all?(days_of_week, fn day -> | ||
Enum.member?( | ||
Enum.map(Date.range(start_date, end_date), fn date -> Date.day_of_week(date) end), | ||
Enum.map(date_range(start_date, end_date), fn date -> Date.day_of_week(date) end), | ||
DayOfWeek.day_number(day) | ||
) | ||
end) -> | ||
|
@@ -285,4 +285,12 @@ defmodule Arrow.DisruptionRevision do | |
changeset | ||
end | ||
end | ||
|
||
defp date_range(start_date, end_date) do | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Address new deprecation warnings where it's required to provide a step of -1 if There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think the code below is correct but what you meant in this comment was |
||
if Date.compare(start_date, end_date) == :gt do | ||
Date.range(start_date, end_date, -1) | ||
else | ||
Date.range(start_date, end_date) | ||
end | ||
end | ||
end |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,7 +17,7 @@ defmodule ArrowWeb.CoreComponents do | |
use Phoenix.Component | ||
|
||
alias Phoenix.LiveView.JS | ||
import ArrowWeb.Gettext | ||
use Gettext, backend: ArrowWeb.Gettext | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
|
||
@doc """ | ||
Renders a modal. | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -51,11 +51,6 @@ defmodule ArrowWeb.ShapeController do | |
conn | ||
|> put_flash(:errors, reason) | ||
|> render(:new_bulk, errors: reason, shapes_upload: reset_upload) | ||
|
||
error -> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Dialyzer flags this clause as unreachable, and I agree. |
||
conn | ||
|> put_flash(:errors, error) | ||
|> render(:new_bulk, errors: error, shapes_upload: reset_upload) | ||
end | ||
end | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,11 +14,10 @@ defmodule Arrow.MixProject do | |
releases: releases(), | ||
dialyzer: [ | ||
plt_add_apps: [:mix], | ||
plt_add_deps: :transitive, | ||
plt_add_deps: :app_tree, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
flags: [ | ||
:unmatched_returns | ||
], | ||
ignore_warnings: ".dialyzer.ignore-warnings" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Dialyzer complained about |
||
] | ||
], | ||
preferred_cli_env: ["test.integration": :test], | ||
test_coverage: [tool: LcovEx, ignore_paths: ["deps/"]] | ||
|
@@ -60,11 +59,11 @@ defmodule Arrow.MixProject do | |
{:gettext, "~> 0.11"}, | ||
{:guardian, "~> 2.0"}, | ||
{:hackney, "~> 1.9"}, | ||
{:httpoison, "~> 1.6"}, | ||
{:httpoison, "~> 2.2"}, | ||
{:ja_serializer, github: "mbta/ja_serializer", branch: "master"}, | ||
{:jason, "~> 1.0"}, | ||
{:lcov_ex, "~> 0.2", only: [:dev, :test], runtime: false}, | ||
{:mox, "~> 1.0.0", only: :test}, | ||
{:mox, "~> 1.2", only: :test}, | ||
{:oban, "~> 2.18"}, | ||
{:phoenix_ecto, "~> 4.0"}, | ||
{:phoenix_live_reload, "~> 1.5", only: :dev}, | ||
|
@@ -76,17 +75,17 @@ defmodule Arrow.MixProject do | |
{:phoenix, "~> 1.7.12"}, | ||
{:plug_cowboy, "~> 2.1"}, | ||
{:telemetry, "~> 1.2", override: true}, | ||
{:telemetry_poller, "~> 0.4"}, | ||
{:telemetry_metrics, "~> 0.4"}, | ||
{:telemetry_poller, "~> 1.1"}, | ||
{:telemetry_metrics, "~> 1.0"}, | ||
{:postgrex, ">= 0.0.0"}, | ||
# If react_phoenix changes, check assets/src/ReactPhoenix.js, too | ||
{:react_phoenix, "1.3.1"}, | ||
{:tzdata, "~> 1.1"}, | ||
{:ueberauth_cognito, "0.4.0"}, | ||
{:ueberauth_oidcc, "~> 0.4.0"}, | ||
{:ueberauth, "~> 0.10"}, | ||
{:wallaby, "~> 0.30.6", runtime: false, only: :test}, | ||
{:sentry, "~> 8.0"}, | ||
{:wallaby, "~> 0.30", runtime: false, only: :test}, | ||
{:sentry, "~> 10.7"}, | ||
{:tailwind, "~> 0.2", runtime: Mix.env() == :dev}, | ||
{:heroicons, | ||
github: "tailwindlabs/heroicons", | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://hexdocs.pm/sentry/upgrade-10-x.html#what-do-i-have-to-do