Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable PSA Crypto API tests in the simulator #1668

Merged
merged 2 commits into from
Jun 28, 2023

Conversation

mdalzellarm
Copy link
Contributor

In this PR, code is introduced to allow the simulator to interface with PSA Crypto functionality. When enabled with --features psa-crypto-api, the simulator will use all possible PSA enabled functions, and where PSA functionality is not available, will continue to use MBed TLS functions.

sim/mcuboot-sys/build.rs Outdated Show resolved Hide resolved
sim/mcuboot-sys/build.rs Outdated Show resolved Hide resolved
sim/mcuboot-sys/csupport/config-add-psa-crypto.h Outdated Show resolved Hide resolved
sim/mcuboot-sys/csupport/config-add-psa-crypto.h Outdated Show resolved Hide resolved
sim/mcuboot-sys/csupport/config-add-psa-crypto.h Outdated Show resolved Hide resolved
sim/mcuboot-sys/csupport/config-add-psa-crypto.h Outdated Show resolved Hide resolved
sim/mcuboot-sys/csupport/config-add-psa-crypto.h Outdated Show resolved Hide resolved
sim/mcuboot-sys/csupport/config-rsa-kw.h Show resolved Hide resolved
@davidvincze
Copy link
Collaborator

@mdalzellarm may I ask you the split (if required) and squash the last commit which contains only fixes for the previous two?
After that can you rebase the patch stack? Force push is fine.

The CI tests were failing because the latest changes were pushed with an e-mail address other than matthew.dalzell@arm.com.

@adeaarm
Copy link
Contributor

adeaarm commented Jun 27, 2023

Hi @mdalzellarm , could you sort out the rebase correctly? I can see 58 commits now and the CI is still failing

adeaarm and others added 2 commits June 28, 2023 09:41
If the psa-crypto-api feature is defined, the simulator will
initialize the PSA Crypto API exactly once. It needs also to
enable the test external RNG as the assumption is that the
PSA subsystem is configured to use MBEDTLS_PSA_CRYPTO_EXTERNAL_RNG

Signed-off-by: David Brown <david.brown@linaro.org>
Signed-off-by: Antonio de Angelis <Antonio.deAngelis@arm.com>
Signed-off-by: Matthew Dalzell <matthew.dalzell@arm.com>
Change-Id: Id02727b8673867ecf1e4fbbdfa3c4b6d6f98f8df
This patch enables psa-crypto-api feature

Signed-off-by: Matthew Dalzell <matthew.dalzell@arm.com>
Signed-off-by: Antonio de Angelis <Antonio.deAngelis@arm.com>
@davidvincze davidvincze merged commit 34d5a69 into mcu-tools:main Jun 28, 2023
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: sim Affects the simulator crypto Encryption support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants