boot: zephyr: Remove broken target config header feature #2069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove broken target config header feature.
This has been broken for more than 6 years, and seeing as nobody noticed
it should be ok to remove it.
Broken because if(EXISTS path-to-file-or-directory) uses relative path.
From cmake documentation:
"Behavior is well-defined only for explicit full paths".
Secondly ${BOARD}.h does not account for changes introduced in hwmv2
where BOARD_QUALIFIER maybe should be handled as well.
Also, who will put their board config files here?
Signed-off-by: Joakim Andersson <joerchan@gmail.com>
nordicjm
approved these changes
Sep 24, 2024
de-nordic
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove broken target config header feature.
This has been broken for more than 6 years, and seeing as nobody noticed it should be ok to remove it.
Broken because if(EXISTS path-to-file-or-directory) uses relative path. From cmake documentation:
"Behavior is well-defined only for explicit full paths".
Secondly ${BOARD}.h does not account for changes introduced in hwmv2 where BOARD_QUALIFIER maybe should be handled as well.
Also, who will put their board config files here?