Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox previews fetch() keepalive support #24656

Merged
merged 2 commits into from
Oct 25, 2024

Conversation

chrisdavidmills
Copy link
Contributor

Summary

Firefox 132 ships the fetch() keepalive option in Nightly and early Beta builds.

This PR adds Fx preview support for api.fetch (as used for Window.fetch() and WorkerGlobalScope.fetch()) and Request.keepalive (doesn't yet have a docs page, but I'm going to change that).

It also adds a data point for the init.keepalive parameter of the Request() constructor, which just copies the same data from the other places.

See https://bugzilla.mozilla.org/show_bug.cgi?id=1906952 for the shipping bug.

Test results and supporting details

Related issues

Docs issue: mdn/content#36120

@github-actions github-actions bot added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Oct 7, 2024
Comment on lines +224 to +253
"chrome": {
"version_added": "66"
},
"chrome_android": "mirror",
"deno": {
"version_added": false
},
"edge": {
"version_added": "15"
},
"firefox": {
"version_added": "preview"
},
"firefox_android": "mirror",
"ie": {
"version_added": false
},
"nodejs": {
"version_added": "18.0.0"
},
"oculus": "mirror",
"opera": "mirror",
"opera_android": "mirror",
"safari": {
"version_added": "13"
},
"safari_ios": "mirror",
"samsunginternet_android": "mirror",
"webview_android": "mirror",
"webview_ios": "mirror"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did you determine the support status for the other browsers?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just copied the data for the init.keepalive parameter from the fetch.json data. They are two different ways of implementing the same thing (Request() constructor, versus directly inside the fetch() call), so they are going to be the same.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Did you test the init.keepalive parameter in Node.js, or did you assume it's supported in the same version as the parent feature?

When comparing the data here against fetch.json, I noticed that there is no nodejs entry for the subfeature there, should we add it there?

"init_keepalive_parameter": {
"__compat": {
"description": "<code>init.keepalive</code> parameter",
"support": {
"chrome": {
"version_added": "66"
},
"chrome_android": "mirror",
"deno": {
"version_added": false
},
"edge": {
"version_added": "15"
},
"firefox": {
"version_added": false
},
"firefox_android": "mirror",
"ie": {
"version_added": false
},
"oculus": "mirror",
"opera": "mirror",
"opera_android": "mirror",
"safari": {
"version_added": "13"
},
"safari_ios": "mirror",
"samsunginternet_android": "mirror",
"webview_android": "mirror",
"webview_ios": "mirror"
},
"status": {
"experimental": false,
"standard_track": true,
"deprecated": false
}
}
},

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, added. I assumed that init.keepalive is just supported, the same as in the fetch() data.

@caugner caugner changed the title Add Fx132 preview support for fetch() keepalive Firefox previews fetch() keepalive support Oct 25, 2024
@caugner caugner merged commit b28ebf7 into mdn:main Oct 25, 2024
6 checks passed
@caugner caugner mentioned this pull request Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants