Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox previews fetch() keepalive support #24656

Merged
merged 2 commits into from
Oct 25, 2024
Merged

Firefox previews fetch() keepalive support #24656

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b6e9d68
Add Fx132 preview support for fetch() keepalive
chrisdavidmills Oct 7, 2024
7a61ae2
add Node JS support for Request.keepalive, add MDN URL
chrisdavidmills Oct 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 49 additions & 1 deletion api/Request.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,6 +213,53 @@
}
}
},
"init_keepalive_parameter": {
"__compat": {
"description": "<code>init.keepalive</code> parameter",
"mdn_url": "https://developer.mozilla.org/docs/Web/API/Request/keepalive",
"spec_url": "https://fetch.spec.whatwg.org/#dom-requestinit-keepalive",
"tags": [
"web-features:fetch-keepalive"
],
"support": {
"chrome": {
"version_added": "66"
},
"chrome_android": "mirror",
"deno": {
"version_added": false
},
"edge": {
"version_added": "15"
},
"firefox": {
"version_added": "preview"
},
"firefox_android": "mirror",
"ie": {
"version_added": false
},
"nodejs": {
"version_added": "18.0.0"
},
"oculus": "mirror",
"opera": "mirror",
"opera_android": "mirror",
"safari": {
"version_added": "13"
},
"safari_ios": "mirror",
"samsunginternet_android": "mirror",
"webview_android": "mirror",
"webview_ios": "mirror"
Comment on lines +225 to +254
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did you determine the support status for the other browsers?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just copied the data for the init.keepalive parameter from the fetch.json data. They are two different ways of implementing the same thing (Request() constructor, versus directly inside the fetch() call), so they are going to be the same.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Did you test the init.keepalive parameter in Node.js, or did you assume it's supported in the same version as the parent feature?

When comparing the data here against fetch.json, I noticed that there is no nodejs entry for the subfeature there, should we add it there?

browser-compat-data/api/_globals/fetch.json

Lines 195 to 233 in ad4f44f

"init_keepalive_parameter": {
"__compat": {
"description": "<code>init.keepalive</code> parameter",
"support": {
"chrome": {
"version_added": "66"
},
"chrome_android": "mirror",
"deno": {
"version_added": false
},
"edge": {
"version_added": "15"
},
"firefox": {
"version_added": false
},
"firefox_android": "mirror",
"ie": {
"version_added": false
},
"oculus": "mirror",
"opera": "mirror",
"opera_android": "mirror",
"safari": {
"version_added": "13"
},
"safari_ios": "mirror",
"samsunginternet_android": "mirror",
"webview_android": "mirror",
"webview_ios": "mirror"
},
"status": {
"experimental": false,
"standard_track": true,
"deprecated": false
}
}
},

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, added. I assumed that init.keepalive is just supported, the same as in the fetch() data.

},
"status": {
"experimental": false,
"standard_track": true,
"deprecated": false
}
}
},
"init_priority_parameter": {
"__compat": {
"description": "<code>init.priority</code> parameter",
Expand Down Expand Up @@ -1084,6 +1131,7 @@
},
"keepalive": {
"__compat": {
"mdn_url": "https://developer.mozilla.org/docs/Web/API/Request/keepalive",
"spec_url": "https://fetch.spec.whatwg.org/#ref-for-dom-request-keepalive②",
"support": {
"chrome": {
Expand All @@ -1097,7 +1145,7 @@
"version_added": "15"
},
"firefox": {
"version_added": false
"version_added": "preview"
},
"firefox_android": "mirror",
"ie": {
Expand Down
5 changes: 4 additions & 1 deletion api/_globals/fetch.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,12 +207,15 @@
"version_added": "15"
},
"firefox": {
"version_added": false
"version_added": "preview"
},
"firefox_android": "mirror",
"ie": {
"version_added": false
},
"nodejs": {
"version_added": "18.0.0"
},
"oculus": "mirror",
"opera": "mirror",
"opera_android": "mirror",
Expand Down