Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(notecards,callouts): reduce borders #10943

Merged
merged 3 commits into from
Apr 19, 2024

Conversation

caugner
Copy link
Contributor

@caugner caugner commented Apr 17, 2024

Summary

(MP-1060)

Problem

The notecards and callouts still have grey border, which is inconsistent to other parts of MDN where we removed them (e.g. code blocks).

Solution

Remove the border from notecards and callouts, and reduce the left emphasis border.


Screenshots

Before

image

After

image

How did you test this change?

Ran yarn && yarn dev locally and looked at these pages/sections:

@caugner caugner requested a review from a team as a code owner April 17, 2024 17:47
@caugner caugner changed the title enhance(notecards): remove border enhance(notecards): reduce borders Apr 18, 2024
@caugner caugner changed the title enhance(notecards): reduce borders enhance(notecards,callouts): reduce borders Apr 18, 2024
@LeoMcA LeoMcA self-assigned this Apr 19, 2024
Copy link
Member

@LeoMcA LeoMcA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@caugner caugner merged commit e313193 into main Apr 19, 2024
15 checks passed
@caugner caugner deleted the MP-1060-remove-notecard-borders branch April 19, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants