refactor: better error handling when parsing events #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chapati23
reviewed
Aug 5, 2024
| block: Number(receipt.blockNumber), | ||
| event, | ||
| txHash: log.transactionHash, | ||
| if (isProposalCreatedEvent(event)) { |
There was a problem hiding this comment.
Is there a case when this can fail silently that we should handle explicilty? i.e. there's no else block for when this event fails the type guard
chapati23
pushed a commit
that referenced
this pull request
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an improvement over the way events were being parsed in #4, mainly introducing a way to distinguish events by checking their signature on the log topics, so that we can be sure the right ABI is being used when decoding the event, eliminating the unnecessary try/catch blocks in the previous implementation. I also added a few asserts in places that shouldn't be reachable unless there's a wrong assumption in the way events are being parsed.