cargo: Run build.rs to get extra --cfg args #13779
Conversation
xclaesse
force-pushed
the
cargo-build-rs
branch
2 times, most recently
from
ed2e434
to
db26175
Compare
There was a problem hiding this comment.
As I've said before, we should not be doing this. At all. We cannot reliably run build.rs, the garden path of cases that actually (and really slowly) manage to successfully run also do not need to be a build.rs so using meson/meson.build will be a superior experience, etc.
The system-deps patch does look quite nice though :) and it's very good that we can do it without build.rs.
There was a problem hiding this comment.
Basically, what you actually want is rust-lang/cargo#7178 and to have people opt into that via run_command(), which we already document as an escape hatch to do whatever you want as long as meson doesn't take responsibility for it.
This returns --target value from rustc command line, or the native target.
xclaesse
force-pushed
the
cargo-build-rs
branch
from
db26175
to
449eb4a
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -34,6 +34,7 @@ | |||
| from .. import mparser | |||
| from ..environment import Environment | |||
| from ..interpreterbase import SubProject | |||
| from ..compilers.rust import RustCompiler | |||
Check notice
Code scanning / CodeQL
Unused import Note
Based on top of #12952.