nasm: Avoid changing multipass optimization levels #13911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the -O argument is set according to the meson optimization level, but this is a bad idea as it can break assembly code relying on certain instructions or offsets being a particular size. There's not really any benefit of using a non-default value (if anything, debugging becomes more difficult when the output changes!), and the nasm manual even explicitly points out that it should be changed from the default "only if you need the finer programmer-level control of output".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the -O argument is set according to the meson optimization level, but this is a bad idea as it can break assembly code relying on certain instructions or offsets being a particular size.
There's not really any benefit of using a non-default value (if anything, debugging becomes more difficult when the output changes!), and the nasm manual even explicitly points out that it should be changed from the default "only if you need the finer programmer-level control of output".