Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nasm: Avoid changing multipass optimization levels #13911

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

nasm: Avoid changing multipass optimization levels #13911

wants to merge 1 commit into from

Commits on Nov 16, 2024

  1. nasm: Avoid changing multipass optimization levels 

    Currently the -O argument is set according to the meson optimization
level, but this is a bad idea as it can break assembly code relying
on certain instructions or offsets being a particular size.

There's not really any benefit of using a non-default value (if anything,
debugging becomes more difficult when the output changes!), and the nasm
manual even explicitly points out that it should be changed from the
default "only if you need the finer programmer-level control of output".
    @Gramner
    Gramner committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    f1b8705 View commit details
    Browse the repository at this point in the history