ImageBuffer: prevent additional copy converting from RGBA to RGB #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you very much. All tests have passed. Merged |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
np.astype will perform a full copy of the array, which is very slow for large images (was taking 30ms for a 1920x1080 image). Our application requires grabbing these images in realtime, and this was taking significant portion of the time. You can avoid this copy if the array is contiguous. However, if the texture buffer is RGBA, the array won't be contiguous, so I disabled RGBA in the output texture. This improved the performance of grabbing images from the engine
If RGBA isn't used anywhere else, the frame_buffer_properties can go directly into ImageBuffer as I have it now. If not, perhaps it should go into BaseCamera or RGBCamera, or be based on the CamMask that you have selected