Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop ADAL to unblock pipeline #6687

Merged
merged 5 commits into from
Sep 6, 2023
Merged

Conversation

Danieladu
Copy link
Collaborator

@Danieladu Danieladu commented Aug 29, 2023

Fixes #minor

Description

ADAL library (Microsoft.IdentityModel.Clients.ActiveDirectory,Microsoft.Azure.Services.AppAuthentication ) has been marked deprecated and would block the Azure pipeline on 23 September.

Totally remove ADAL code to unblock the pipeline

@Danieladu
Copy link
Collaborator Author

CI exception:
image
I think it make sense? Because we remove the ADAL code, which has been marked deprecate longlong ago.

@Danieladu Danieladu marked this pull request as ready for review August 30, 2023 10:00
@Danieladu Danieladu requested a review from a team as a code owner August 30, 2023 10:00
Copy link
Collaborator

@sw-joelmut sw-joelmut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Danieladu,

The changes are looking good! About the CI exception, this PR is introducing breaking changes.

@tracyboehrer, to merge this PR you'll need to exclude these classes from the compat check by adding them to the list in the ApiCompatExcludeClasses variable.

For more information, check out the PR #5124.

@Danieladu
Copy link
Collaborator Author

I have updated the variable, but seems not work
image
Is there any additional thing should i do?

@sw-joelmut
Copy link
Collaborator

Hi @Danieladu,

We want to share our findings regarding the ApiCompatExcludeClasses variable.
The variable is working as expected, but you will need to execute the pipeline (new run, not retry) for the changes to be applied.
imagen

Additionally, there is another way of excluding the classes.
All compatibility issues shown in the Compatibility Check pipeline's section can be excluded by adding them to the ApiCompatBaseline.txt file.
imagen

@Danieladu
Copy link
Collaborator Author

Danieladu commented Sep 5, 2023

@microsoft/botframework-sdk @tracyboehrer please help review this PR which blocks the SDK pipeline and also ABS pipeline.

@tracyboehrer tracyboehrer merged commit 2d09ba8 into microsoft:main Sep 6, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants