-
Notifications
You must be signed in to change notification settings - Fork 484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop ADAL to unblock pipeline #6687
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Danieladu,
The changes are looking good! About the CI exception, this PR is introducing breaking changes.
@tracyboehrer, to merge this PR you'll need to exclude these classes from the compat check by adding them to the list in the ApiCompatExcludeClasses
variable.
For more information, check out the PR #5124.
Hi @Danieladu, We want to share our findings regarding the Additionally, there is another way of excluding the classes. |
@microsoft/botframework-sdk @tracyboehrer please help review this PR which blocks the SDK pipeline and also ABS pipeline. |
Fixes #minor
Description
ADAL library (Microsoft.IdentityModel.Clients.ActiveDirectory,Microsoft.Azure.Services.AppAuthentication ) has been marked deprecated and would block the Azure pipeline on 23 September.
Totally remove ADAL code to unblock the pipeline