Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent the more options button in environments cards from being cut off when text is scaled to 200% #3761

Merged

Conversation

bbonaby
Copy link
Contributor

@bbonaby bbonaby commented Sep 4, 2024

Summary of the pull request

When text is scaled at 200 percent the horizontal 3 dots button on the environment cards appear to be cutoff. This is an accessibility issue. Issue happens because as the scale of the text increases, the text bleeds into the buttons padding causing it to looks as if it was clipped/missing a dot character.

Changes:

  • Remove the padding from the button as it is not needed for this button

Before changes:

before no padding change

After changes
After padding changes

References and relevant issues

Detailed description of the pull request / Additional comments

Validation steps performed

PR checklist

@bbonaby bbonaby added the Needs-Second Pull request that needs another approval label Sep 5, 2024
@bbonaby bbonaby merged commit ad813a7 into main Sep 6, 2024
4 checks passed
@krschau krschau removed the Needs-Second Pull request that needs another approval label Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"More Options (. . . )" button in added environments is partially visible after applying text scaling
3 participants