Linux XDP support #3849
Linux XDP support #3849
Conversation
…i/xdp_split_functional
…i/xdp_split_functional
…i/xdp_split_functional
…i/xdp_split_functional
…i/xdp_split_functional
…i/xdp_split_functional
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
ami-GS
force-pushed
the
dev/daiki/xdp_split_functional
branch
from
ddfdcfa to
47086f2
Compare
ami-GS
force-pushed
the
dev/daiki/xdp_split_functional
branch
from
47086f2 to
9cd42d0
Compare
src/platform/CMakeLists.txt
Outdated
| find_library(BPF_LIB libbpf.so) | ||
| else () | ||
| # XDP Tools and libbpf paths | ||
| set(XDP_TOOLS_DIR ${PROJECT_SOURCE_DIR}/submodules/xdp-tools) |
There was a problem hiding this comment.
Do we only need the submodule if we support build from source?
There was a problem hiding this comment.
If so, I'd prefer not to need another submodule.
There was a problem hiding this comment.
I thought there is no strong reason to delete.
Enabling xdp from source required huge effort. People from other communities (xdp/ebpf etc.) can easily involve with this option.
There was a problem hiding this comment.
If we need the submodule to compile/link against the library that's one thing, but if this is here just to build the source, I prefer to not have that, at least not right now, in this PR. You can move the code to a follow up PR to save it.
Time has shown that keeping submodules and their builds up to date has been painful with openssl. We want as few of these dependencies as possible.
ami-GS
force-pushed
the
dev/daiki/xdp_split_functional
branch
from
c178671 to
98a1222
Compare
| @@ -64,6 +64,9 @@ elseif (APPLE) | |||
| set(CX_PLATFORM "darwin") | |||
| elseif (UNIX) | |||
| set(CX_PLATFORM "linux") | |||
| file(STRINGS "/etc/lsb-release" LSB_RELEASE_CONTENT) | |||
There was a problem hiding this comment.
This line broke our Alpine docker build, using /etc/os-release would be better as it is present in both distributions.
Description
Linux xdp datapath implementation
Testing
All tests are passing?
Documentation
Not official support yet