Skip to content

[POC|Invalid] Testing vcpkg without installed MSVC #45544

[POC|Invalid] Testing vcpkg without installed MSVC

[POC|Invalid] Testing vcpkg without installed MSVC #45544

Triggered via pull request November 13, 2024 22:55
Status Failure
Total duration 15s
Artifacts

untrustedPR.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

3 errors
Check
All vcpkg.json files must be formatted. To fix this problem, run: ./vcpkg format-manifest ports/*/vcpkg.json It should make the following changes:```diff diff --git a/ports/msvc/vcpkg.json b/ports/msvc/vcpkg.json index e802359..796547c 100644 --- a/ports/msvc/vcpkg.json +++ b/ports/msvc/vcpkg.json @@ -1,8 +1,8 @@ -{ - "name": "msvc", - "version": "17.11.5", - "license": "MIT", - "dependencies": [ - "vcpkg-tool-lessmsi" - ] -} +{ + "name": "msvc", + "version": "17.11.5", + "license": "MIT", + "dependencies": [ + "vcpkg-tool-lessmsi" + ] +} diff --git a/ports/vcpkg-cmake/vcpkg.json b/ports/vcpkg-cmake/vcpkg.json index 0d08796..349832c 100644 --- a/ports/vcpkg-cmake/vcpkg.json +++ b/ports/vcpkg-cmake/vcpkg.json @@ -3,7 +3,7 @@ "version-date": "2024-04-23", "documentation": "https://learn.microsoft.com/vcpkg/maintainers/functions/vcpkg_cmake_configure", "license": "MIT", - "dependencies" : [ + "dependencies": [ "msvc" ] } ```
Check
PRs must add only one version, and must not modify any published versions. When making any changes to a library, the version or port-version in vcpkg.json must be modified, and the version database updated. Making the following changes will fix this problem:```diff error: checked-in files for vcpkg-cmake have changed but the version was not updated version: 2024-04-23 old SHA: e74aa1e8f93278a8e71372f1fa08c3df420eb840 new SHA: 25b4e2249702e6c5f690c0e2385c881747ae5378 Did you remember to update the version or port version? Use --overwrite-version to bypass this check See https://learn.microsoft.com/vcpkg/commands/add-version?WT.mc_id=vcpkg_inproduct_cli#--overwrite-version for more information. ***No files were updated*** ```
Check
After committing all other changes, the version database must be updated. This can be done by running the following commands after committing your changes: git add -u && git commit git checkout 772f784ba8d1add92420bd6b81d4cd6a91fb36ac -- versions ./vcpkg x-add-version --all