[ignition-cmake2] Add new port 🤖 #10014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
traversaro
changed the title
traversaro
changed the title
NancyLi1013
suggested changes
Feb 11, 2020
Some ignition libraries (such as ignition-cmake2) already install the CMake config file in the location required by vcpkg
traversaro
force-pushed
the
add-ignition-cmake2
branch
from
65e66c4
to
ca6e6d0
Compare
|
The CI now fails due to a qt5-tools regression, but I am not sure how this is related to the PR. |
|
It seems that there is something wrong with Linux platform. |
|
/azp run |
2 similar comments
|
/azp run |
|
/azp run |
|
Hi @NancyLi1013 , I think I addressed all your comments, so I am not sure why the PR is listed under "waiting for response" . Let me know if I need to do something, thanks! |
|
Hi @traversaro Sorry for the late response. |
JackBoosY
suggested changes
Mar 3, 2020
JackBoosY
approved these changes
Mar 4, 2020
|
Alright, looks good to me! |
|
Thanks a lot @strega-nil @NancyLi1013 @JackBoosY ! |
Toxe
pushed a commit
to Toxe/vcpkg
that referenced
this pull request
Mar 11, 2020
* ignition-modularscripts: move CMake config files only if necessary Some ignition libraries (such as ignition-cmake2) already install the CMake config file in the location required by vcpkg * Add new port ignition-cmake2
Toxe
added a commit
to Toxe/vcpkg
that referenced
this pull request
Mar 11, 2020
This reverts commit 1c7c0f6.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a port for ignition-cmake2. As discussed in #7781, different major version of ignition robotics libraries (https://ignitionrobotics.org/) can be installed side by side, so each new major version is added as a new port.
In particular, ignition-cmake2 is a dependency for Gazebo 11 (http://gazebosim.org/blog/gazebo11) and for Ignition Robotics Citadel (that contains Ignition Gazebo 3, see https://www.openrobotics.org/blog/2019/12/11/ignition-citadel-released).
As far as I was able to test, this port should support all the triplets.
Related issue: