Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ignition-msgs1, ignition-transport4] Add new ports 🤖 #8044

Merged
merged 1 commit into from
Sep 12, 2019

Conversation

traversaro
Copy link
Contributor

@traversaro traversaro commented Sep 4, 2019

Write new ports using the ignition-modularscript port added in #7781 .
The ports are for the ignition-msgs ( https://ignitionrobotics.org/libs/msgs ) and ignition-transport ( https://ignitionrobotics.org/libs/transport ) libraries for robotics applications.

Related issue: #8014 .

@traversaro
Copy link
Contributor Author

The failures on triplets x64-uwp, arm64-windows, arm-uwp are expected, as ignition-msgs1 requires some modifications to support cross compilation, and instead of working directly on a patch I opened an issue upstream to make sure that the modification will be eventually merged upstream (see https://bitbucket.org/ignitionrobotics/ign-msgs/issues/34/add-support-for-cross-compilation).

Instead, the failure in x64-linux is quite strange, and can be investigated further, as there are some strange linking failures w.r.t. to protobuf.

@cbezault cbezault assigned dan-shaw and vicroms and unassigned dan-shaw Sep 4, 2019
@traversaro
Copy link
Contributor Author

The x64-linux failure is apparently due to the fact that the linking order depends when linking static libraries using ld, and the order used in the build system of ignition-msgs for linking protobuf libraries was wrong, see the PR at https://bitbucket.org/ignitionrobotics/ign-msgs/pull-requests/151/fix-linking-order-of-protocol-buffers/diff for more details.

@traversaro
Copy link
Contributor Author

In the latest commit the failure in x64-linux have been solved, and the only failures are the expected one on cross-compilation targets.

@traversaro
Copy link
Contributor Author

There is another Linux failure because the logic to find UUID in ignition-transport4 requires pkg-config to be installed, and pkg-config is not installed in the test machines.

Write new ports using the ignition-modularscript port added in microsoft#7781
@traversaro
Copy link
Contributor Author

Fix for uuid problem described in #8044 (comment) added in the latest version of the PR.

@traversaro traversaro changed the title [ignition-msgs1, ignition-transport4] Add new ports [ignition-msgs1, ignition-transport4] Add new ports 🤖 Sep 11, 2019
@traversaro
Copy link
Contributor Author

Robot emoji added to the title (see #7781 (comment)), I think the PR is now ready for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants