Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User/elormcoch/wsl extension fix #1804

Merged
merged 6 commits into from
Jan 25, 2024

Conversation

ElormCoch
Copy link
Contributor

Adapts the launch and debug commands based on whether the extension is run in a remote environment.

@ElormCoch ElormCoch force-pushed the user/elormcoch/wsl-extension-fix branch from e2c5623 to c707dcc Compare December 19, 2023 17:47
Copy link
Contributor

@vidorteg vidorteg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix 👏 @ElormCoch, most of code LGTM, I left a couple of comments, could you PTAL?

src/extension.ts Outdated Show resolved Hide resolved
src/extension.ts Show resolved Hide resolved
@ElormCoch ElormCoch marked this pull request as ready for review January 23, 2024 18:59
@ElormCoch ElormCoch force-pushed the user/elormcoch/wsl-extension-fix branch from c07d45d to 24b80c3 Compare January 23, 2024 19:21
Copy link
Contributor

@vidorteg vidorteg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of nits but aside from that LGTM 🥳

src/utils.ts Outdated Show resolved Hide resolved
test/extension.test.ts Outdated Show resolved Hide resolved
@ElormCoch ElormCoch closed this Jan 24, 2024
@ElormCoch ElormCoch reopened this Jan 24, 2024
@ElormCoch ElormCoch force-pushed the user/elormcoch/wsl-extension-fix branch from f155265 to 807713c Compare January 25, 2024 16:57
@ElormCoch
Copy link
Contributor Author

@microsoft-github-policy-service agree company="Microsoft"

@vidorteg
Copy link
Contributor

@microsoft-github-policy-service rerun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error while fetching list of available targets No available targets to attach.
2 participants