Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shared drawers #81

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

mazes-80
Copy link
Contributor

Drawers formspec adds a shared checkbox.
When activated it allows people not able to dig the node to put/get item from those containers

@mazes-80
Copy link
Contributor Author

it also resize user inventory to 8x4 when not using mineclone

@mazes-80
Copy link
Contributor Author

There is a setting to disable the shared checkbox, put/get feature

@mazes-80
Copy link
Contributor Author

I didn't even see that PR addressed the same issue.
The way I make public drawers on my local server is more fine-grained.

@S-S-X
Copy link
Contributor

S-S-X commented Feb 21, 2023

Personally, as a game mechanism concept, I would prefer #67 simply because it does not use boring formspec checkbox but instead utilizes drawer upgrades to make drawers public.

@mazes-80
Copy link
Contributor Author

mazes-80 commented Feb 23, 2023

1/ Visibility
I play on the linuxforks.de "Free Toilet Paper" but never realized the way to make drawers public
A simple note in the formspec would allow to make this easier to see.

2/ Storage capacity

instead utilizes drawer upgrades to make drawers public.

There is one drawback to this approach: drawers max size decreases
Private drawers max size = 32 * 13 * 4 * stack_size
Public drawers max size = 32 * 13 * 3 * stack_size

Adding a public list to inventory may solve this, but all interaction would then require to be reviewed.
Adding "drawers:public_material_upgrade" for each material may allow not to lose the multiplier

@S-S-X
Copy link
Contributor

S-S-X commented Feb 23, 2023

I play on the linuxforks.de "Free Toilet Paper" but never realized the way to make drawers public
A simple note in the formspec would allow to make this easier to see.

Not sure how it works there but yes simple documentation in formspec sure is good thing.
Could even add explanation for capacity upgrades as well, possibly even dynamic status text telling how it currently works, if it is shared or not and what is current max capacity.

There is one drawback to this approach: drawers max size decreases

I could possibly also see this as a game mechanism which intentionally introduces trade off to limit what features one could have at once.
But yes it is debatable if this is or isn't good use case for these things, not worst for sure but I guess question is if it is good enough or even harmful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants