fix: remove enclosure progression save data on shared entry #2831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shared entry does not link to any user and therefore should not display any saved progression. Curiously, the progression of a user (the one that shared ?) was still integrated in the page. This does not make sens regarding the sharing feature itself. It is also a leak of user personal information onto a public page. I simply removed the data from the template when the user object is not present. I tested the change on "regular" entry page, ensuring the save progression feature still works, and on shared page checking if any error happened in the JavaScript console. Everything seems in order.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shared entry does not link to any user and therefore should not display any saved progression. Curiously, the progression of a user (the one that shared ?) was still integrated in the page. This does not make sens regarding the sharing feature itself. It is also a leak of user personal information onto a public page.
I simply removed the data from the template when the user object is not present. I tested the change on "regular" entry page, ensuring the save progression feature still works, and on shared page checking if any error happened in the JavaScript console. Everything seems in order.
Do you follow the guidelines?