Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove enclosure progression save data on shared entry #2831

Merged
merged 1 commit into from
Sep 4, 2024

Commits on Sep 3, 2024

  1. fix: remove progression save on shared entry

    Shared entry does not link to any user and therefore should not display
    any saved progression. Curiously, the progression of a user (the one that shared ?)
    was still integrated in the page. This does not make sens regarding the sharing
    feature itself. It is also a leak of user personal information onto a public page.
    
    I simply removed the data from the template when the user object is not present.
    I tested the change on "regular" entry page, ensuring the save progression feature
    still works, and on shared page checking if any error happened in the JavaScript console.
    Everything seems in order.
    ztec committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    f03a04a View commit details
    Browse the repository at this point in the history