cleanup(reader/handler): calling store.UpdateFeed and store.UpdateFeedError in a defer function #2879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes sure that we are always calling the following functions: * originalFeed.ScheduleNextCheck * store.UpdateFeed * store.UpdateFeedError And we only call them in a single place regardless which branch is taken inside function. The store functions within them will udpate the value in database. This change aims to reduce "unknown unknowns" in the codes. With this change, we won't miss calling above functions.
shizunge
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes sure that we are always calling the following functions:
The store functions within them will udpate the value in database.
This change aims to reduce "unknown unknowns" in the codes. With this change, we won't miss calling above functions.
Do you follow the guidelines?