Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup(reader/handler): calling store.UpdateFeed and store.UpdateFeedError in a defer function #2879

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

cleanup(reader/handler): calling store.UpdateFeed and store.UpdateFeedError in a defer function #2879

wants to merge 1 commit into from

Commits on Oct 7, 2024

  1. calling store.UpdateFeed and store.UpdateFeedError in a defer function 

    This makes sure that we are always calling the following functions:
* originalFeed.ScheduleNextCheck
* store.UpdateFeed
* store.UpdateFeedError
And we only call them in a single place regardless which branch is taken inside function.

The store functions within them will udpate the value in database.

This change aims to reduce "unknown unknowns" in the codes. With this change, we won't miss calling above functions.
    @shizunge
    shizunge committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    2231ec2 View commit details
    Browse the repository at this point in the history