Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix offline_min_samples in submission checker and #1569 #1571

Merged
merged 5 commits into from
Jan 22, 2024

Conversation

arjunsuresh
Copy link
Contributor

No description provided.

@arjunsuresh arjunsuresh requested a review from a team as a code owner January 19, 2024 11:54
Copy link

github-actions bot commented Jan 19, 2024

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@@ -1527,7 +1544,7 @@ def __init__(
self.seeds = self.base["seeds"]
self.test05_seeds = self.base["test05_seeds"]
self.accuracy_target = self.base["accuracy-target"]
self.accuracy_upper_limit = self.base["accuracy-upper-limit"]
self.accuracy_upper_limit = self.base.get("accuracy-upper-limit")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's set an empty default value to avoid errors

self.accuracy_upper_limit = self.base.get("accuracy-upper-limit", {})

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Pablo. I missed that it's a dictionary. Fixed now.

@pgmpablo157321
Copy link
Contributor

@arjunsuresh Can you update this branch again?

@arjunsuresh
Copy link
Contributor Author

Sure. Just did.

@pgmpablo157321 pgmpablo157321 merged commit f21c39d into mlcommons:master Jan 22, 2024
7 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants