-
Notifications
You must be signed in to change notification settings - Fork 538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix offline_min_samples in submission checker and #1569 #1571
Conversation
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
@@ -1527,7 +1544,7 @@ def __init__( | |||
self.seeds = self.base["seeds"] | |||
self.test05_seeds = self.base["test05_seeds"] | |||
self.accuracy_target = self.base["accuracy-target"] | |||
self.accuracy_upper_limit = self.base["accuracy-upper-limit"] | |||
self.accuracy_upper_limit = self.base.get("accuracy-upper-limit") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's set an empty default value to avoid errors
self.accuracy_upper_limit = self.base.get("accuracy-upper-limit", {})
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you Pablo. I missed that it's a dictionary. Fixed now.
@arjunsuresh Can you update this branch again? |
Sure. Just did. |
No description provided.