fix: #331 mergeParams always true for internal services #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Freezystem
reviewed
Aug 30, 2023
Co-authored-by: Nico <freezystem@gmail.com>
Freezystem
approved these changes
Sep 4, 2023
icebob
requested changes
Sep 7, 2023
| @@ -452,6 +452,11 @@ module.exports = { | |||
| urlPath = urlPath.replace(this._isscRe, "$"); | |||
| let action = urlPath; | |||
|
|
|||
| // #331 Always merge parameters for internal services | |||
| if (action.startsWith("$")) { | |||
| route.opts.mergeParams = true; | |||
There was a problem hiding this comment.
This changes is too late here because the merging is happening in line 442.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered that
mergeParams: falsewas the cause of the issue #331.Developers should continue to use this configuration without experiencing side effects in internal services.
I implemented a minor workaround in
src/index.js:L455to force parameter merging for internal services, and it resolved the issue.