Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: #331 mergeParams always true for internal services #332

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: #331 mergeParams always true for internal services #332

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
641a19f
fix: #331 mergeParams always true for internal services
ggondim Aug 28, 2023
4e4b365
Including @freezystem's suggestion
ggondim Aug 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -452,6 +452,11 @@ module.exports = {
urlPath = urlPath.replace(this._isscRe, "$");
let action = urlPath;

// #331 Always merge parameters for internal services
if (action.startsWith("$")) {
route.opts.mergeParams = true;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes is too late here because the merging is happening in line 442.

}

// Resolve aliases
if (foundAlias) {
const alias = foundAlias.alias;
Expand Down