Skip to content

Commit

Permalink
Merge pull request #32 from molssi-seamm/dev
Browse files Browse the repository at this point in the history
Fixed issues introduced in BandStructure and DOS steps
  • Loading branch information
seamm committed Mar 5, 2023
2 parents dd4fa72 + 5e1b983 commit a989735
Show file tree
Hide file tree
Showing 6 changed files with 11 additions and 4 deletions.
4 changes: 4 additions & 0 deletions HISTORY.rst
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@
History
=======

2023.3.5 -- Fixed issues with bandstructure and DOS
* The bandstructure and DOS substeps updated to work with changes in the underlying
classes. This had been missed earlier.

2023.2.17.2 -- Fixed bug with xTB parameters
* xTB runs have a blank line in results.tag which caused a crash.

Expand Down
3 changes: 3 additions & 0 deletions dftbplus_step/band_structure.py
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,9 @@ def __init__(

super().__init__(flowchart=flowchart, title=title, extension=extension)

self._calculation = "band structure"
self._model = None
self._metadata = dftbplus_step.metadata
self.parameters = dftbplus_step.BandStructureParameters()

self.description = ["Band Structure for DFTB+"]
Expand Down
3 changes: 3 additions & 0 deletions dftbplus_step/dos.py
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,9 @@ def __init__(self, flowchart=None, title="DOS", extension=None, logger=logger):

super().__init__(flowchart=flowchart, title=title, extension=extension)

self._calculation = "DOS"
self._model = None
self._metadata = dftbplus_step.metadata
self.parameters = dftbplus_step.DOSParameters()

self.description = ["DOS for DFTB+"]
Expand Down
2 changes: 0 additions & 2 deletions dftbplus_step/tk_band_structure.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ def __init__(
w=200,
h=50,
my_logger=logger,
keyword_metadata=None,
):
"""Initialize the graphical Tk DFTB+ BandStructure step
Expand All @@ -39,7 +38,6 @@ def __init__(
w=w,
h=h,
my_logger=my_logger,
keyword_metadata=keyword_metadata,
)

def right_click(self, event):
Expand Down
2 changes: 0 additions & 2 deletions dftbplus_step/tk_dos.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ def __init__(
w=200,
h=50,
my_logger=logger,
keyword_metadata=None,
):
"""Initialize the graphical Tk DFTB+ DOS step
Expand All @@ -40,7 +39,6 @@ def __init__(
w=w,
h=h,
my_logger=my_logger,
keyword_metadata=keyword_metadata,
)

def right_click(self, event):
Expand Down
1 change: 1 addition & 0 deletions docs/conf.py
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,7 @@
html_theme_options = {
"github_url": "https://github.com/molssi-seamm/dftbplus_step",
"twitter_url": "https://twitter.com/MolSSI_NSF",
"icon_links": [],
"logo": {
"image_light": "SEAMM logo.png",
"image_dark": "SEAMM Inverted 288x181.png",
Expand Down

0 comments on commit a989735

Please sign in to comment.