🧹 Allow printing data queries without an assessment #4693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Boolean data queries will have an assessment. When we display them as data queries, we do not want an assessment
| return print.Assessment(bundle, assessment) | ||
| } | ||
|
|
||
| return print.Datas(bundle, results) |
There was a problem hiding this comment.
just to double check: is this PR just a restructure/cleanup or are there functional changes?
from what I see the only thing that happens here is that we've moved the for loop into its own Datas func that still gets called if assessment is nil
There was a problem hiding this comment.
ah, i see the use case in mondoohq/cnspec#1438 for extracting that
There was a problem hiding this comment.
This just splits the function into 2 so that it can be used from cnspec
preslavgerchev
approved these changes
Sep 25, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Boolean data queries will have an assessment. When we display them as data queries, we do not want an assessment