Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Don't render assessments for data queries #1438

Merged
merged 2 commits into from
Sep 25, 2024
Merged

🐛 Don't render assessments for data queries #1438

merged 2 commits into from
Sep 25, 2024

Conversation

jaym
Copy link
Contributor

@jaym jaym commented Sep 25, 2024

Boolean data queries had an assessment and would print that instead of just the result

Requires mondoohq/cnquery#4693

@jaym
🐛 Don't render assessments for data queries
5930a73 
Boolean data queries had an assessment and would print that instead of
just the result
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 25, 2024 •
edited
Loading

Test Results

  1 files  ±0   24 suites  ±0   19s ⏱️ ±0s
403 tests ±0  402 ✅ ±0  1 💤 ±0  0 ❌ ±0 
404 runs  ±0  403 ✅ ±0  1 💤 ±0  0 ❌ ±0 

Results for commit fe5b534. ± Comparison against base commit dfff538.

♻️ This comment has been updated with latest results.

@preslavgerchev preslavgerchev mentioned this pull request Sep 25, 2024
Merged
@vjeffrey vjeffrey merged commit 2312224 into main Sep 25, 2024
14 checks passed
@vjeffrey vjeffrey deleted the jdm/bool-data-queries branch September 25, 2024 15:14
@github-actions github-actions bot locked and limited conversation to collaborators Sep 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@preslavgerchev preslavgerchev preslavgerchev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jaym @preslavgerchev @vjeffrey