Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Don't render assessments for data queries #1438

Merged
merged 2 commits into from
Sep 25, 2024
Merged

🐛 Don't render assessments for data queries #1438

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5930a73
🐛 Don't render assessments for data queries
jaym Sep 25, 2024
fe5b534
update cnquery
jaym Sep 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cli/reporter/print_compact.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -476,7 +476,7 @@ func (r *defaultReporter) printAssetQueries(resolved *policy.ResolvedPolicy, rep
dataQueriesOutput := ""
resolved.WithDataQueries(func(id string, query *policy.ExecutionQuery) {
data := query.Code.FilterResults(results)
result := r.Reporter.Printer.Results(query.Code, data)
result := r.Reporter.Printer.Datas(query.Code, data)
if result == "" {
return
}
Expand Down
2 changes: 1 addition & 1 deletion cli/reporter/render_asset_overview.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ func renderAssetOverview(print *printer.Printer, policyObj *policy.Policy, repor

// print data results
filteredResults := codeBundle.FilterResults(results)
value := print.Results(codeBundle, filteredResults)
value := print.Datas(codeBundle, filteredResults)

table = append(table, row{
Title: query.Title,
Expand Down
2 changes: 1 addition & 1 deletion cli/reporter/render_policy.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ func renderDataQueries(print *printer.Printer, policyObj *policy.Policy, report
}
}

result := print.Results(codeBundle, filteredResults)
result := print.Datas(codeBundle, filteredResults)
result = strings.ReplaceAll(result, "\n", NewLineCharacter)
res.WriteString(" Result:")
writeQueryCompact(res, result)
Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ require (
github.com/spf13/pflag v1.0.6-0.20201009195203-85dd5c8bc61c
github.com/spf13/viper v1.19.0
github.com/stretchr/testify v1.9.0
go.mondoo.com/cnquery/v11 v11.23.0
go.mondoo.com/cnquery/v11 v11.23.1-0.20240925141453-78405c55870a
go.mondoo.com/mondoo-go v0.0.0-20240819110653-687d75eb1183
go.mondoo.com/ranger-rpc v0.6.3
go.opentelemetry.io/otel v1.30.0
Expand Down
2 changes: 2 additions & 0 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -941,6 +941,8 @@ go.etcd.io/etcd/client/pkg/v3 v3.5.1/go.mod h1:IJHfcCEKxYu1Os13ZdwCwIUTUVGYTSAM3
go.etcd.io/etcd/client/v2 v2.305.1/go.mod h1:pMEacxZW7o8pg4CrFE7pquyCJJzZvkvdD2RibOCCCGs=
go.mondoo.com/cnquery/v11 v11.23.0 h1:DsC4JKSpG/lWHhI6rEgusUa+ukMq4EJAe3skXMR1ww4=
go.mondoo.com/cnquery/v11 v11.23.0/go.mod h1:genVEY+EytYTwhE9wW0A/Tq6bZysygBXXLPcthpto9Y=
go.mondoo.com/cnquery/v11 v11.23.1-0.20240925141453-78405c55870a h1:TdVoxRXpW7vj5Ehd0VyhTaZAxUCUoAX0K7NB4bXxeYg=
go.mondoo.com/cnquery/v11 v11.23.1-0.20240925141453-78405c55870a/go.mod h1:genVEY+EytYTwhE9wW0A/Tq6bZysygBXXLPcthpto9Y=
go.mondoo.com/mondoo-go v0.0.0-20240819110653-687d75eb1183 h1:IpUOrXDa31euZKYfbBEkyZTTUGK3CtF2l8Wy1T0YG/o=
go.mondoo.com/mondoo-go v0.0.0-20240819110653-687d75eb1183/go.mod h1:lF3LCT7QHJekrCjQjYkectEQ/atQ0UELtsuBuXHNRxo=
go.mondoo.com/ranger-rpc v0.6.3 h1:XpJatFv0m6FxiVwgwKVlDkO6EcjGf6TnoJSlNh3d7Ks=
Expand Down
Loading