DRIVERS-2648 Add AWS Secrets handling for serverless #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NoahStapp
requested changes
Jan 16, 2024
.evergreen/serverless/README.md
Outdated
| $DRIVERS_TOOLS/.evergreen/serverless/setup-secrets.sh serverless-next | ||
| ``` | ||
|
|
||
| The full task group might look like: |
There was a problem hiding this comment.
What is this referencing? Feels very out of nowhere when compared to the previous lines.
| . $SCRIPT_DIR/../handle-paths.sh | ||
|
|
||
| # Ensure that secrets have already been set up. | ||
| if [ -f "$SCRIPT_DIR/secrets-export.sh" ]; then |
There was a problem hiding this comment.
What if this file doesn't exist?
There was a problem hiding this comment.
Legacy invocations won't have the file, the individual env var checks below will handle it.
|
|
||
| SCRIPT_DIR=$(dirname ${BASH_SOURCE[0]}) | ||
| . $SCRIPT_DIR/../handle-paths.sh | ||
| pushd $SCRIPT_DIR |
There was a problem hiding this comment.
Should there be a matching popd at the end of this script?
NoahStapp
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds credentials for
serverless_next.Tested with mongodb/mongo-python-driver#1428 and mongodb/mongo-go-driver#1473.