-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix support for RHEL 7.0 #486
Conversation
# Install from github to get the latest mongo-orchestration. | ||
python -m pip install -q --upgrade 'https://github.com/mongodb/mongo-orchestration/archive/master.tar.gz' | ||
# Install from github to get the latest mongo-orchestration, fall back on published wheel. | ||
python -m pip install -q --upgrade 'https://github.com/mongodb/mongo-orchestration/archive/master.tar.gz' || python -m pip install -q --upgrade mongo-orchestration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We intentionally install from master, why fallback to the published one? Like how could the source install ever fail?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On rhel 7.0 (but not rhel 7.9), we cannot install hatchling because of the version of glibc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh that's lame, could you add a comment explaining that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait why does hatchling install fail? It looks like a pure python library: https://pypi.org/project/hatchling/#files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, the real issue is that find_python3 is using Python 3.6, for which there is no matching version of hatchling. I'll update the comment, because we could still end up in a whack-a-mole situation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah so the real issue is that we're using Python 3.6 but mongo-orc@master requires Python 3.8+
We may have to do a new release of mongo-orc to get this to work. Otherwise the fallback won't work with newer mongod versions. |
Passing build: https://spruce.mongodb.com/version/66d8ad0bd0d8e80007870224/tasks?sorts=STATUS%3AASC%3BBASE_STATUS%3ADESC