Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix support for RHEL 7.0 #486

Merged
merged 5 commits into from
Sep 4, 2024
Merged

Conversation

blink1073
Copy link
Member

@blink1073 blink1073 commented Sep 4, 2024

# Install from github to get the latest mongo-orchestration.
python -m pip install -q --upgrade 'https://github.com/mongodb/mongo-orchestration/archive/master.tar.gz'
# Install from github to get the latest mongo-orchestration, fall back on published wheel.
python -m pip install -q --upgrade 'https://github.com/mongodb/mongo-orchestration/archive/master.tar.gz' || python -m pip install -q --upgrade mongo-orchestration
Copy link
Contributor

@ShaneHarvey ShaneHarvey Sep 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We intentionally install from master, why fallback to the published one? Like how could the source install ever fail?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On rhel 7.0 (but not rhel 7.9), we cannot install hatchling because of the version of glibc.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh that's lame, could you add a comment explaining that?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait why does hatchling install fail? It looks like a pure python library: https://pypi.org/project/hatchling/#files

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, the real issue is that find_python3 is using Python 3.6, for which there is no matching version of hatchling. I'll update the comment, because we could still end up in a whack-a-mole situation.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah so the real issue is that we're using Python 3.6 but mongo-orc@master requires Python 3.8+

@ShaneHarvey
Copy link
Contributor

We may have to do a new release of mongo-orc to get this to work. Otherwise the fallback won't work with newer mongod versions.

@blink1073
Copy link
Member Author

@blink1073 blink1073 merged commit cbc1f18 into mongodb-labs:master Sep 4, 2024
48 checks passed
@blink1073 blink1073 deleted the fix-rhel7 branch September 4, 2024 19:42
adriandole pushed a commit to adriandole/drivers-evergreen-tools that referenced this pull request Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants