Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix support for RHEL 7.0 #486

Merged
merged 5 commits into from
Sep 4, 2024
Merged

Fix support for RHEL 7.0 #486

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d88b273
Fix support for rhel 7
blink1073 Sep 4, 2024
a15a546
try with rhel70-small
blink1073 Sep 4, 2024
8623092
try with fallback
blink1073 Sep 4, 2024
e76af5f
add comment
blink1073 Sep 4, 2024
7be073f
update comment
blink1073 Sep 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .evergreen/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1236,6 +1236,10 @@ axes:
display_name: "Ubuntu 20.04 (ARM64)"
run_on: ubuntu2004-arm64-small

- id: rhel70-small
display_name: "RHEL 7"
run_on: rhel70-small

- id: rhel87-power8
display_name: "RHEL 8 (POWER8)"
run_on: rhel81-power8-small
Expand Down
6 changes: 4 additions & 2 deletions .evergreen/start-orchestration.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,10 @@ echo "Creating virtual environment 'venv'..."
venvcreate "${PYTHON:?}" venv
echo "Creating virtual environment 'venv'... done."

# Install from github to get the latest mongo-orchestration.
python -m pip install -q --upgrade 'https://github.com/mongodb/mongo-orchestration/archive/master.tar.gz'
# Install from github to get the latest mongo-orchestration, fall back on published wheel.
# The fallback was added to accommodate versions of Python 3 for which there is no compatible version
# of the hatchling backend used by mongo-orchestration.
python -m pip install -q --upgrade 'https://github.com/mongodb/mongo-orchestration/archive/master.tar.gz' || python -m pip install -q --upgrade mongo-orchestration
Copy link
Contributor

@ShaneHarvey ShaneHarvey Sep 4, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We intentionally install from master, why fallback to the published one? Like how could the source install ever fail?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On rhel 7.0 (but not rhel 7.9), we cannot install hatchling because of the version of glibc.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh that's lame, could you add a comment explaining that?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait why does hatchling install fail? It looks like a pure python library: https://pypi.org/project/hatchling/#files

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, the real issue is that find_python3 is using Python 3.6, for which there is no matching version of hatchling. I'll update the comment, because we could still end up in a whack-a-mole situation.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's the failing build: https://spruce.mongodb.com/task/drivers_tools_tests_os_requires_50__os_requires_50~rhel70_small_auth~auth_ssl~ssl_test_5.0_standalone_patch_cf39786af0437b52a0f9829190d55b11bfbfe354_66d8ab2dfbe79f0007abf9fb_24_09_04_18_47_19/logs?execution=0

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah so the real issue is that we're using Python 3.6 but mongo-orc@master requires Python 3.8+

python -m pip list
cd $DRIVERS_TOOLS

Expand Down
Loading