GODRIVER-2607 Remove legacy shell from test scripts #1429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blink1073
had a problem deploying
to
api-report
GitHub Actions
Failure
blink1073
had a problem deploying
to
api-report
GitHub Actions
Failure
|
cc @alcaeus, I think this should be the prototype PR for other drivers to follow. |
qingyang-hu
reviewed
Oct 17, 2023
.evergreen/config.yml
Outdated
| @@ -144,7 +145,7 @@ functions: | |||
| # If this was a patch build, doing a fresh clone would not actually test the patch | |||
| cp -R ${PROJECT_DIRECTORY}/ $DRIVERS_TOOLS | |||
| else | |||
| git clone https://github.com/mongodb-labs/drivers-evergreen-tools.git $DRIVERS_TOOLS | |||
| git clone --branch GODRIVER-2607 https://github.com/blink1073/drivers-evergreen-tools.git $DRIVERS_TOOLS | |||
There was a problem hiding this comment.
Shall we wait for the merging of mongodb-labs/drivers-evergreen-tools#365?
API Change ReportNo changes found! |
qingyang-hu
approved these changes
Oct 18, 2023
blink1073
added a commit
to blink1073/mongo-go-driver
that referenced
this pull request
Oct 19, 2023
(cherry picked from commit 1066e2a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GODRIVER-2607
Summary
Use new test scripts in Drivers-Evergreen-Tools.
Background & Motivation
Clean up EVG config and avoid the need for the legacy
mongoshell.Note that we have to use
ec2.assume_roleto get the secrets because there is no instance profile associated withthe macos hosts.
Relies on mongodb-labs/drivers-evergreen-tools#365