Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix leading slash exit in fuzz test #1813

Merged

Conversation

prestonvasquez
Copy link
Collaborator

Summary

In CI we are getting the following:

[2024/09/13 15:55:05.224] tar: Removing leading `/' from member names
[2024/09/13 15:55:05.224] Command 'shell.exec' in function 'run-fuzz-tests' (step 2 of 2) failed: shell script encountered problem: exit code 1.

Suggest applying the solution here: https://unix.stackexchange.com/a/59244

Background & Motivation

Fuzz tests are failing at tar.

@@ -63,7 +63,7 @@ done
# If the fuzz directory exists, then tar it up in preparation to upload to S3.
if [ -d $PROJECT_DIRECTORY/fuzz ]; then
echo "Tarring up fuzz directory"
tar -czf $PROJECT_DIRECTORY/fuzz.tgz $PROJECT_DIRECTORY/fuzz
tar -czf $PROJECT_DIRECTORY/fuzz.tgz --absolute-names $PROJECT_DIRECTORY/fuzz
Copy link
Collaborator Author

@prestonvasquez prestonvasquez Sep 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note the fuzz test still fails in CI, but because of a legitimate issue. See GODRIVER-3346 for more information.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the proper way is to instead cd $PROJECT_DIRECTORY and then run tar -cfz fuzz.tgz ./fuzz

@mongodb-drivers-pr-bot mongodb-drivers-pr-bot bot added the priority-3-low Low Priority PR for Review label Sep 16, 2024
Copy link
Contributor

API Change Report

No changes found!

.evergreen/run-fuzz.sh Outdated Show resolved Hide resolved
Co-authored-by: Steven Silvester <steve.silvester@mongodb.com>
Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@prestonvasquez prestonvasquez merged commit 884fb42 into mongodb:master Sep 17, 2024
31 of 34 checks passed
@prestonvasquez prestonvasquez deleted the fix-leading-slash-fuzz-exit branch September 17, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority-3-low Low Priority PR for Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants