PHPC-2343: Require PHP 8.1 #1631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alcaeus
requested review from
GromNaN and
jmikola
and removed request for
GromNaN
alcaeus
force-pushed
the
phpc-2343-require-php-8.1
branch
from
a1cd411
to
488bc9c
Compare
alcaeus
commented
Sep 5, 2024
| @@ -60,24 +60,6 @@ ZEND_TSRMLS_CACHE_EXTERN() | |||
|
|
|||
| zend_object_handlers* phongo_get_std_object_handlers(void); | |||
|
|
|||
| #define PHONGO_CE_FINAL(ce) \ | |||
There was a problem hiding this comment.
This macro was unused for a while.
| #else | ||
| #define PHONGO_CE_DISABLE_SERIALIZATION(ce) \ | ||
| do { \ | ||
| ce->ce_flags |= ZEND_ACC_NOT_SERIALIZABLE; \ |
There was a problem hiding this comment.
I was able to replace this macro with a non-serializable annotation in the stub files 🎉
| @@ -65,31 +65,6 @@ | |||
| #define PHONGO_BREAK_INTENTIONALLY_MISSING | |||
| #endif | |||
|
|
|||
| #if PHP_VERSION_ID >= 80000 | |||
There was a problem hiding this comment.
I've replaced all these macros with their underlying symbols
jmikola
approved these changes
Sep 5, 2024
alcaeus
force-pushed
the
phpc-2343-require-php-8.1
branch
from
488bc9c
to
e15c1a2
Compare
GromNaN
approved these changes
Sep 6, 2024
| @@ -7,6 +7,7 @@ | |||
|
|
|||
| namespace MongoDB\Driver; | |||
|
|
|||
| /** @not-serializable */ | |||
There was a problem hiding this comment.
Is this new? Which software understand this attribute? If found this RFC that would introduce an attribute for that.
There was a problem hiding this comment.
This is used by the gen_stub tool to add the ZEND_ACC_NOT_SERIALIZABLE flag to the class definition: https://github.com/php/php-src/blob/2f3224ea4105c3bebb7db0bee0a57e62dc560a66/build/gen_stub.php#L3472..L3474
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
alcaeus
added a commit
that referenced
this pull request
Oct 15, 2024
* v1.x: PHPC-2460: Use zend_zval_type_name instead of internal macros (#1714) PHPC-2464: Emit deprecation notice for negative "limit" Query option (#1710) PHPC-2458: Deprecate float arg for UTCDateTime constructor (#1695) Document how to run part of the test suite (#1690) Bump version to 1.21-dev (#1661) Update branch names for GHA workflows (#1646) PHPC-2343: Require PHP 8.1 (#1631)
alcaeus
added a commit
that referenced
this pull request
Oct 17, 2024
* v1.x: PHPC-2460: Use zend_zval_type_name instead of internal macros (#1714) PHPC-2464: Emit deprecation notice for negative "limit" Query option (#1710) PHPC-2458: Deprecate float arg for UTCDateTime constructor (#1695) Document how to run part of the test suite (#1690) Bump version to 1.21-dev (#1661) Update branch names for GHA workflows (#1646) PHPC-2343: Require PHP 8.1 (#1631)
alcaeus
added a commit
that referenced
this pull request
Oct 29, 2024
* v1.x: PHPC-1247: Update links to PHP.net docs (#1735) PHPC-2460: Use zend_zval_type_name instead of internal macros (#1714) PHPC-2464: Emit deprecation notice for negative "limit" Query option (#1710) PHPC-2458: Deprecate float arg for UTCDateTime constructor (#1695) Document how to run part of the test suite (#1690) Bump version to 1.21-dev (#1661) Update branch names for GHA workflows (#1646) PHPC-2343: Require PHP 8.1 (#1631)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHPC-2343
Best viewed commit by commit, as this removes a lot of compatibility logic necessary for older PHP versions.