Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHPC-2452: Warn if --with-openssl-dir is used #1677

Merged
merged 1 commit into from
Sep 23, 2024
+4 −0
Merged

PHPC-2452: Warn if --with-openssl-dir is used #1677

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions scripts/autotools/libmongoc/CheckSSL.m4
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,10 @@ PHP_ARG_WITH([openssl-dir],
[auto],
[no])

if test "$PHP_OPENSSL_DIR" != "auto"; then
AC_MSG_WARN([Using --with-openssl-dir is deprecated and will be removed in a future version.])
fi
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing locally:

$ phpize
$ ./configure --with-openssl-dir=foo

Output:

...
checking whether to enable crypto and TLS... auto
checking deprecated option for OpenSSL library path... foo
configure: WARNING: Using --with-openssl-dir is deprecated and will be removed in a future version.
checking for cc options needed to detect all undeclared functions... none needed
checking for openssl >= 1.0.1... yes
...


AS_IF([test "$PHP_MONGODB_SSL" = "openssl" -o "$PHP_MONGODB_SSL" = "auto"],[
found_openssl="no"
Expand Down