PHPC-2452: Warn if --with-openssl-dir is used #1677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alcaeus
approved these changes
Sep 23, 2024
jmikola
commented
Sep 23, 2024
| @@ -26,6 +26,10 @@ PHP_ARG_WITH([openssl-dir], | |||
| [auto], | |||
| [no]) | |||
|
|
|||
| if test "$PHP_OPENSSL_DIR" != "auto"; then | |||
| AC_MSG_WARN([Using --with-openssl-dir is deprecated and will be removed in a future version.]) | |||
| fi | |||
There was a problem hiding this comment.
Testing locally:
$ phpize
$ ./configure --with-openssl-dir=foo
Output:
...
checking whether to enable crypto and TLS... auto
checking deprecated option for OpenSSL library path... foo
configure: WARNING: Using --with-openssl-dir is deprecated and will be removed in a future version.
checking for cc options needed to detect all undeclared functions... none needed
checking for openssl >= 1.0.1... yes
...
This was referenced Sep 23, 2024
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/PHPC-2452