PYTHON-4504 Update mod_wsgi test to not call setup.py #1684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NoahStapp
approved these changes
Jun 14, 2024
blink1073
added a commit
to blink1073/mongo-python-driver
that referenced
this pull request
Jun 14, 2024
(cherry picked from commit fe0faf7)
ShaneHarvey
reviewed
Jun 14, 2024
| @@ -19,7 +19,7 @@ fi | |||
| PYTHON_VERSION=$(${PYTHON_BINARY} -c "import sys; sys.stdout.write('.'.join(str(val) for val in sys.version_info[:2]))") | |||
|
|
|||
| # Ensure the C extensions are installed. | |||
| ${PYTHON_BINARY} setup.py build_ext -i | |||
| ${PYTHON_BINARY} -m pip install -e . | |||
There was a problem hiding this comment.
We can't do pip install here because it will install on the evergreen host itself. We need to create a venv first.
blink1073
added a commit
that referenced
this pull request
Jun 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.