test(NODE-3211): convert gridfs tests to unified test format #4179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baileympearson
commented
Jul 16, 2024
| @@ -56,15 +56,41 @@ export interface GridFSFile { | |||
|
|
|||
| /** @internal */ | |||
| export interface GridFSBucketReadStreamPrivate { | |||
| /** | |||
There was a problem hiding this comment.
I debugged the one skipped test for a bit before deciding to skip it - I added these comments as I was debugging and decided to leave them.
baileympearson
force-pushed
the
gridfs-tests-unified-format
branch
from
6fff048
to
a500649
Compare
baileympearson
commented
Jul 17, 2024
|
encompassed in #4180 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
Converts legacy gridfs tests to unified format.
Is there new documentation needed for these changes?
What is the motivation for this change?
Release Highlight
Fill in title or leave empty for no highlight
Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript