-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(NODE-3211): convert gridfs tests to unified test format #4179
Closed
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
import { loadSpecTests } from '../../spec'; | ||
import { runUnifiedSuite } from '../../tools/unified-spec-runner/runner'; | ||
|
||
describe('GridFS Unified Tests', function () { | ||
runUnifiedSuite(loadSpecTests('gridfs'), ({ description }) => { | ||
return description === 'download when final chunk is missing' ? `TODO(NODE-6279): throw a missing chunk error when last chunk is missing` : false; | ||
}); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
# GridFS Tests | ||
|
||
______________________________________________________________________ | ||
|
||
## Introduction | ||
|
||
The YAML and JSON files in this directory are platform-independent tests meant to exercise a driver's implementation of | ||
GridFS. These tests utilize the [Unified Test Format](../../unified-test-format/unified-test-format.md). | ||
|
||
## Conventions for Expressing Binary Data | ||
|
||
The unified test format allows binary stream data to be expressed and matched with `$$hexBytes` (for uploads) and | ||
`$$matchesHexBytes` (for downloads), respectively; however, those operators are not supported in all contexts, such as | ||
`insertData` and `outcome`. When binary data must be expressed as a base64-encoded string | ||
([Extended JSON](../../extended-json.md) for a BSON binary type), the test SHOULD include a comment noting the | ||
equivalent value in hexadecimal for human-readability. For example: | ||
|
||
```yaml | ||
data: { $binary: { base64: "ESIzRA==", subType: "00" } } # hex 11223344 | ||
``` | ||
|
||
Creating the base64-encoded string for a sequence of hexadecimal bytes is left as an exercise to the developer. Consider | ||
the following PHP one-liner: | ||
|
||
```shell-session | ||
$ php -r 'echo base64_encode(hex2bin('11223344')), "\n";' | ||
ESIzRA== | ||
``` |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I debugged the one skipped test for a bit before deciding to skip it - I added these comments as I was debugging and decided to leave them.