-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(NODE-6284): make sparsity and trimFactor optional #4189
Conversation
e0ec286
to
b9d141e
Compare
e16b674
to
e3f2f2b
Compare
test/integration/client-side-encryption/client_side_encryption.spec.test.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're putting the release highlights of this change into: #4141 correct? Could you fill those out with the changes we're making here?
...ion/client-side-encryption/client_side_encryption.prose.23.range_encryption_defaults.test.ts
Outdated
Show resolved
Hide resolved
This is a fix to changes made in another PR that hasn't been released. There are no release notes for this - as far as users are concerned, this work never happened. |
Maybe I am overlooking something in this PR. Is it not the case that I figure that we can still call this a "fix" PR but that this "feature" is a logical part of #4141 in the sense that it is "adding support for range v2" |
I guess that was an oversight. The full feature will be documented in #4190 when the time comes. |
Description
What is changing?
Sparsity and trimFactor, two options for the QE Range, have been marked optional. All range v2 spec tests are syncced. CSFLE prose test 23 has been implemented.
Additionally, the crypto callbacks tests have been removed. The bindings now automatically load crypto callbacks from C++ with all compatible mongodb-client-encryption versions. This means we can no longer spy on or sinon stub the cypto callbacks, so these tests are broken.
Is there new documentation needed for these changes?
What is the motivation for this change?
Double check the following
npm run check:lint
scripttype(NODE-xxxx)[!]: description
feat(NODE-1234)!: rewriting everything in coffeescript