Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(NODE-6268): update dev dependencies and add dependabot config #4196

Merged
merged 7 commits into from
Aug 23, 2024

Conversation

baileympearson
Copy link
Contributor

@baileympearson baileympearson commented Aug 15, 2024

Description

What is changing?

This is a pretty "large" PR - large in terms of files changed, not large in terms of actual substantial changes. This PR

  • performs the quarterly dependency upgrade
  • upgrades to eslint v9, upgrades all other eslint-related packages to their eslint-v9 corresponding versions and fixes all the issues that arose
  • upgrades prettier to 3.x (necessary for compatibility with eslint v9 and eslint-plugin-prettier), which results in a minor reformatting of the codebase
  • adds a dependabot config for future dependency upgrades

I've tried to comment on any substantial changes made as a result of the eslint upgrade (spoiler: there aren't many).

Is there new documentation needed for these changes?

No.

What is the motivation for this change?

Release Highlight

Fill in title or leave empty for no highlight

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@baileympearson baileympearson changed the title update batch 1 chore: update dev dependencies and add dependabot config Aug 16, 2024
@baileympearson baileympearson changed the title chore: update dev dependencies and add dependabot config chore(NODE-6268): update dev dependencies and add dependabot config Aug 16, 2024
package.json Outdated Show resolved Hide resolved
@baileympearson baileympearson marked this pull request as ready for review August 21, 2024 21:18
@W-A-James W-A-James self-assigned this Aug 22, 2024
@W-A-James W-A-James self-requested a review August 22, 2024 14:47
@W-A-James W-A-James added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Aug 22, 2024
package.json Outdated Show resolved Hide resolved
test/tools/mongodb-mock/src/server.js Show resolved Hide resolved
Co-authored-by: Warren James <warren.james@mongodb.com>
@W-A-James W-A-James added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Aug 22, 2024
Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the no-then removals seem to have left empty lines that I would've expected prettier to clean up, fine to leave as is but mentioning if you didn't notice

@W-A-James W-A-James merged commit c54466c into main Aug 23, 2024
30 checks passed
@W-A-James W-A-James deleted the deps branch August 23, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team Review Needs review from team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants