Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(NODE-6268): update dev dependencies and add dependabot config #4196

Merged
merged 7 commits into from
Aug 23, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .eslintignore
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,3 @@
lib
test/disabled
!etc/docs

test/explicit-resource-management
60 changes: 45 additions & 15 deletions .eslintrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,11 @@
},
"plugins": [
"simple-import-sort",
"import",
"@typescript-eslint",
"prettier",
"unused-imports",
"tsdoc",
"mocha",
"github"
"mocha"
],
"extends": [
"eslint:recommended",
Expand Down Expand Up @@ -67,15 +65,17 @@
],
"simple-import-sort/imports": "error",
"simple-import-sort/exports": "error",
"import/first": "error",
"import/newline-after-import": "error",
"import/no-duplicates": "error",
"strict": [
"error",
"global"
],
"@typescript-eslint/no-explicit-any": "off",
"@typescript-eslint/no-non-null-assertion": "error",
// We use redundant type constituents for documentation purposes.
"@typescript-eslint/no-redundant-type-constituents": "off",
"@typescript-eslint/no-empty-function": "error",
"@typescript-eslint/require-await": "off",
"@typescript-eslint/no-unused-expressions": "off",
"@typescript-eslint/consistent-type-imports": [
"error",
{
Expand Down Expand Up @@ -121,12 +121,8 @@
"message": "Do not strictly check typeof undefined (NOTE: currently this rule only detects the usage of 'undefined' string literal so this could be a misfire)"
}
],
"@typescript-eslint/no-unused-vars": [
"error",
{
"argsIgnorePattern": "^_"
}
]
"@typescript-eslint/no-unused-vars": "error",
"no-duplicate-imports": "error"
},
"overrides": [
{
Expand Down Expand Up @@ -168,6 +164,9 @@
"@typescript-eslint/no-empty-function": "off",
"@typescript-eslint/no-this-alias": "off",
"@typescript-eslint/no-unused-vars": "off",
"@typescript-eslint/consistent-type-imports": "off",
// JS test files use require
"@typescript-eslint/no-require-imports": "off",
// Since we use ts-node we should always require the TS code
// Also we have patches to apply to the mock server, so we should always import from there
"no-restricted-modules": [
Expand Down Expand Up @@ -200,6 +199,15 @@
"no-restricted-syntax": "off",
"typescript-eslint/ban-ts-comment": "off",
"no-restricted-imports": "off",
"@typescript-eslint/no-unused-vars": [
"error",
{
"argsIgnorePattern": "^_",
"caughtErrorsIgnorePattern": "^_",
"destructuredArrayIgnorePattern": "^_",
"varsIgnorePattern": "^_"
}
],
"@typescript-eslint/no-restricted-imports": [
"error",
{
Expand Down Expand Up @@ -235,12 +243,23 @@
"@typescript-eslint/restrict-plus-operands": "off",
"@typescript-eslint/restrict-template-expressions": "off",
"@typescript-eslint/require-await": "off",
"@typescript-eslint/no-redundant-type-constituents": "off",
"@typescript-eslint/no-unused-expressions": "off",
"@typescript-eslint/no-explicit-any": "off",
"no-return-await": "off",
"@typescript-eslint/return-await": [
"error",
"always"
],
"github/no-then": "error",
"@typescript-eslint/no-unused-vars": [
"error",
{
"argsIgnorePattern": "^_",
"caughtErrorsIgnorePattern": "^_",
"destructuredArrayIgnorePattern": "^_",
"varsIgnorePattern": "^_"
}
],
"no-restricted-imports": [
"error",
{
Expand All @@ -263,7 +282,7 @@
"tsdoc/syntax": "warn",
"no-console": "off",
"@typescript-eslint/no-explicit-any": "off",
"@typescript-eslint/no-unused-vars": "error",
"@typescript-eslint/no-unused-vars": "off",
"@typescript-eslint/ban-ts-comment": "off",
"@typescript-eslint/no-empty-function": "off"
}
Expand All @@ -276,7 +295,18 @@
],
"parser": "@typescript-eslint/parser",
"rules": {
"unused-imports/no-unused-imports": "error"
"unused-imports/no-unused-imports": "error",
"@typescript-eslint/no-empty-object-type": "off",
"@typescript-eslint/no-unsafe-declaration-merging": "off",
"no-duplicate-imports": "off",
"@typescript-eslint/consistent-type-imports": [
W-A-James marked this conversation as resolved.
Show resolved Hide resolved
"error",
{
"prefer": "type-imports",
"disallowTypeAnnotations": false,
"fixStyle": "separate-type-imports"
}
]
}
}
]
Expand Down
12 changes: 6 additions & 6 deletions .evergreen/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3522,7 +3522,7 @@ tasks:
- func: install dependencies
- func: bootstrap mongo-orchestration
- func: check resource management feature integration
- name: check-types-typescript-next-node-types-20.14.10
- name: check-types-typescript-next-node-types-22.4.1
tags:
- check-types-typescript-next
- typescript-compilation
Expand All @@ -3534,10 +3534,10 @@ tasks:
- {key: NODE_LTS_VERSION, value: '16'}
- {key: NPM_VERSION, value: '9'}
- {key: TS_VERSION, value: next}
- {key: TYPES_VERSION, value: 20.14.10}
- {key: TYPES_VERSION, value: 22.4.1}
- func: install dependencies
- func: check types
- name: check-types-typescript-current-node-types-20.14.10
- name: check-types-typescript-current-node-types-22.4.1
tags:
- check-types-typescript-current
- typescript-compilation
Expand All @@ -3549,7 +3549,7 @@ tasks:
- {key: NODE_LTS_VERSION, value: '16'}
- {key: NPM_VERSION, value: '9'}
- {key: TS_VERSION, value: current}
- {key: TYPES_VERSION, value: 20.14.10}
- {key: TYPES_VERSION, value: 22.4.1}
- func: install dependencies
- func: check types
- name: check-types-typescript-next-node-types-16.x
Expand Down Expand Up @@ -3597,7 +3597,7 @@ tasks:
- {key: TYPES_VERSION, value: 18.11.9}
- func: install dependencies
- func: check types
- name: compile-driver-typescript-current-node-types-20.14.10
- name: compile-driver-typescript-current-node-types-22.4.1
tags:
- compile-driver-typescript-current
- typescript-compilation
Expand All @@ -3609,7 +3609,7 @@ tasks:
- {key: NODE_LTS_VERSION, value: '16'}
- {key: NPM_VERSION, value: '9'}
- {key: TS_VERSION, value: current}
- {key: TYPES_VERSION, value: 20.14.10}
- {key: TYPES_VERSION, value: 22.4.1}
- func: install dependencies
- func: compile driver
- name: download-and-merge-coverage
Expand Down
38 changes: 38 additions & 0 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
# To get started with Dependabot version updates, you'll need to specify which
# package ecosystems to update and where the package manifests are located.
# Please see the documentation for all configuration options:
# https://docs.github.com/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file

version: 2
updates:
- package-ecosystem: "npm" # See documentation for possible values
directory: "/" # Location of package manifests
schedule:
interval: "monthly"
ignore:
# chai is esmodule only.
- dependency-name: "chai"
versions: [">=5.0.0"]
# sinon-chai 4.x+ supports chai 5.x+.
- dependency-name: "sinon-chai"
versions: [">=4.0.0"]
# nyc is Node18+ only starting on nyc@16.x.
- dependency-name: "nyc"
versions: [">=16.0.0"]
# we ignore TS as a part of quarterly dependency updates.
- dependency-name: "typescript"
# stay on the supported major version of gcp-metadata
- dependency-name: "gcp-metadata"
versions: [">=6.0.0"]

versioning-strategy: increase
allow:
- dependency-type: "development"

groups:
development-dependencies:
dependency-type: "development"
applies-to: version-updates
update-types:
- "minor"
- "patch"
Loading