Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(NODE-6317): remove flaky unnecessary assertion #4212

Merged
merged 2 commits into from
Sep 3, 2024

Conversation

baileympearson
Copy link
Contributor

@baileympearson baileympearson commented Aug 29, 2024

Description

What is changing?

This test is flaky on macos.

The assertion removed isn't related to the test description and isn't necessary for the correctness of the test.

Is there new documentation needed for these changes?

What is the motivation for this change?

Release Highlight

Fill in title or leave empty for no highlight

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@baileympearson baileympearson marked this pull request as ready for review August 29, 2024 16:52
@aditi-khare-mongoDB aditi-khare-mongoDB self-assigned this Sep 3, 2024
@aditi-khare-mongoDB aditi-khare-mongoDB added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Sep 3, 2024
Copy link
Contributor

@aditi-khare-mongoDB aditi-khare-mongoDB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aditi-khare-mongoDB aditi-khare-mongoDB merged commit fb13ebf into main Sep 3, 2024
26 of 27 checks passed
@aditi-khare-mongoDB aditi-khare-mongoDB deleted the NODE-6317 branch September 3, 2024 15:22
W-A-James added a commit that referenced this pull request Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants