fix(NODE-6355): respect utf8 validation options when iterating cursors #4214
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
This PR ensures that any BSON utf8 validation options are provided to the deserializer when deserializing cursors.
Since on-demand BSON, cursors are deserialized on-demand. Documents are pulled out of the cursor using
MongoDBResponse.get()
, which returns an unparsed on-demand document. We then deserialize it usingtoObject()
.However, although
MongoDBResponse
correctly applies BSON utf8 options to its deserialization logic, the on-demand document does not. This results in documents retrieved from a cursor being deserialized without the utf8 validation options.Is there new documentation needed for these changes?
What is the motivation for this change?
Release Highlight
Fill in title or leave empty for no highlight
Double check the following
npm run check:lint
scripttype(NODE-xxxx)[!]: description
feat(NODE-1234)!: rewriting everything in coffeescript