-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(NODE-6355): respect utf8 validation options when iterating cursors (6.8) #4220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baileympearson
changed the title
fix(NODE-6355): respect utf8 validation options when iterating cursors
fix(NODE-6355): respect utf8 validation options when iterating cursors (6.8)
Sep 4, 2024
nbbeeken
added
the
Primary Review
In Review with primary reviewer, not yet ready for team's eyes
label
Sep 4, 2024
nbbeeken
requested changes
Sep 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have to change the name of a few variables and run this branches prettier to get the lint task passing. FLE failures are expected because setup has changed since the 6.8 release.
baileympearson
force-pushed
the
cursor-utf8-fix-6.8
branch
from
September 6, 2024 17:16
aa1fbc8
to
68eb03c
Compare
dariakp
reviewed
Sep 6, 2024
dariakp
reviewed
Sep 6, 2024
test/integration/node-specific/bson-options/utf8_validation.test.ts
Outdated
Show resolved
Hide resolved
dariakp
reviewed
Sep 6, 2024
test/integration/node-specific/bson-options/utf8_validation.test.ts
Outdated
Show resolved
Hide resolved
dariakp
reviewed
Sep 6, 2024
test/integration/node-specific/bson-options/utf8_validation.test.ts
Outdated
Show resolved
Hide resolved
dariakp
reviewed
Sep 6, 2024
test/integration/node-specific/bson-options/utf8_validation.test.ts
Outdated
Show resolved
Hide resolved
nbbeeken
reviewed
Sep 6, 2024
test/integration/node-specific/bson-options/utf8_validation.test.ts
Outdated
Show resolved
Hide resolved
nbbeeken
approved these changes
Sep 6, 2024
dariakp
approved these changes
Sep 6, 2024
5 tasks
This was referenced Oct 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
Cursors now respect
enableUtf8Validation
.CI won't run on 6.8 - patch build here: https://spruce.mongodb.com/version/66db46990ef9890007c0f2cb/tasks?sorts=STATUS%3AASC%3BBASE_STATUS%3ADESC
Performance comparison with the 6.8 commit: https://performance-analyzer.server-tig.prod.corp.mongodb.com/perf-analyzer-viz/?comparison_id=66db3c2adbc39a02ac0aef75
Is there new documentation needed for these changes?
What is the motivation for this change?
Release Highlight
Fixed
enableUtf8Validation
optionStarting in v6.8.0 we inadvertently removed the ability to disable UTF-8 validation when deserializing BSON. Validation is normally a good thing, but it was always meant to be configurable and the recent Node.js runtime issues (v22.7.0) make this option indispensable for avoiding errors from mistakenly generated invalid UTF-8 bytes.
Double check the following
npm run check:lint
scripttype(NODE-xxxx)[!]: description
feat(NODE-1234)!: rewriting everything in coffeescript