Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #2

Open
wants to merge 1 commit into
base: add-ssa-cleaner
Choose a base branch
from
Open

Fix #2

wants to merge 1 commit into from

Conversation

zoetrope
Copy link

@zoetrope zoetrope commented Mar 9, 2021

  • Remove manageAllFields and releaseAllFields (I've decided it's not necessary.)
  • Use update instead of JSONPatch in removeBeforeFirstApply to avoid TOCTTOU

@zoetrope
Fix
45c1641 
- Remove manageAllFields and releaseAllFields
- Use update instead of JSONPatch in removeBeforeFirstApply
morimoto-cybozu
morimoto-cybozu approved these changes Mar 9, 2021
View reviewed changes
Copy link
Owner

@morimoto-cybozu morimoto-cybozu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zoetrope zoetrope marked this pull request as ready for review March 15, 2021 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morimoto-cybozu morimoto-cybozu morimoto-cybozu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zoetrope @morimoto-cybozu